-
Notifications
You must be signed in to change notification settings - Fork 0
Stream bluesky documents to kafka #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tom-Willemsen
wants to merge
8
commits into
main
Choose a base branch
from
kafka
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't kill a scan if kafka fails...
rerpha
reviewed
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth an ADR? maybe not yet as it's really a "because we can" atm?
rerpha
reviewed
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Stream bluesky documents to kafka. This enables remote, out-of-process callbacks to trigger from bluesky scans or data-points.
See https://reduce.isis.cclrc.ac.uk/redpanda-console/topics/NDW2922_bluesky?p=-1&s=50&o=-1#messages for an example of msgpack-encoded documents which have been streamed from my dev machine.
This is using the upstream
bluesky-kafka
integration. It looks like that implementation is somewhat used by one or two facilities, but much less than core bluesky. If the upstream implementation causes a problem later, it would be pretty trivial to write our own (direct) wrapper that forwards messages toconfluent-kafka
viamsgpack
directly.Ticket
None
Labels
Acceptance criteria
Documentation
Kafka docs added in 'developer' section.
Not expecting this to be user-facing, so no user-facing docs added.